Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible changes for Image Verification and GPG key installation #380

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented May 10, 2024

SUMMARY

Added the changes required for Image verification and gpg key installation

GitHub Issues
GitHub Issue #
N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • sonic_image_management
OUTPUT

regression-report-sonic-image-management.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@aravindmani-1 aravindmani-1 changed the title Ansible changes for Image Verification Ansible changes for Image Verification and GPG key installation May 10, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is still in draft, but please make sure to add version_added to each new attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aravindmani-1 aravindmani-1 marked this pull request as ready for review August 27, 2024 14:42
@kerry-meyer
Copy link
Collaborator

kerry-meyer commented Oct 25, 2024

Hi Aravind,

Please fix the py3.11/py3.12 sanity errors flagged on this PR so we can proceed with review and merging of this PR.

                    Kerry

@kerry-meyer kerry-meyer added this to the v3.1.0 milestone Oct 25, 2024
@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented Oct 26, 2024

Hi Aravind,

Please fix the py3.11/py3.12 sanity errors flagged on this PR so we can proceed with review and merging of this PR.

                    Kerry

Done. Updated the PR to latest sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants