Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH resource module implementation #462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SSH resource module implementation #462

wants to merge 3 commits into from

Conversation

balasubramaniam-k
Copy link
Contributor

@balasubramaniam-k balasubramaniam-k commented Oct 8, 2024 •
edited
Loading

SUMMARY
Resource module changes for SSH client configurations. SSH server configuration related changes can be accommodated in the same module.

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
sonic_ssh

RELATED PR
ansible-network/resource_module_models#275

OUTPUT
regression-2024-10-04-13-18-53.html.pdf
ssh_config_UT_check_mode.log

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

Balasubramaniam K1 added 3 commits October 2, 2024 17:02
Implementation of SSH resource module.
8845d60
Code changes
b35c370 
1. Handling delete of SSH client algorithms (comma separated string)
when the algorithms remain same and the order of algorithms in input
configuration is different from that of existing.
2. Involving cleanup.
Merge branch 'main' into sonic_ssh
ae33eb7
@ArunSaravananBalachandran ArunSaravananBalachandran added the new_resource_module This pull request adds a new resource module label Oct 8, 2024
@balasubramaniam-k balasubramaniam-k mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerry-meyer kerry-meyer Awaiting requested review from kerry-meyer kerry-meyer is a code owner

@stalabi1 stalabi1 Awaiting requested review from stalabi1 stalabi1 is a code owner

Assignees
No one assigned
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balasubramaniam-k @ArunSaravananBalachandran