-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cable_length attribute to QoS interfaces module #468
Open
ohu1
wants to merge
17
commits into
ansible-collections:main
Choose a base branch
from
ohu1:cable-length
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalabi1
reviewed
Oct 21, 2024
stalabi1
changed the title
cable length support
Add cable_length attribute to QoS interfaces module
Oct 21, 2024
stalabi1
reviewed
Oct 21, 2024
stalabi1
reviewed
Oct 21, 2024
plugins/module_utils/network/sonic/argspec/qos_interfaces/qos_interfaces.py
Outdated
Show resolved
Hide resolved
stalabi1
reviewed
Oct 21, 2024
stalabi1
reviewed
Oct 21, 2024
stalabi1
reviewed
Oct 21, 2024
Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
…interfaces.py Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add 'cable_length' attribute to QoS interfaces module
ISSUE TYPE
COMPONENT NAME
sonic_qos_interfaces
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Regression test with updated testcases.
regression-2024-10-14-cable-length.txt.gz