Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functionality to allow a value of 0 to be configured for the appropriate integer attributes and refactor STP module code #477

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+983 −821
Open

Fix functionality to allow a value of 0 to be configured for the appropriate integer attributes and refactor STP module code #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb60b8a
Fix mst-id bug and refactor STP module code
stalabi1 Oct 29, 2024
253340c
Add fragment
stalabi1 Oct 29, 2024
f84cd94
Update STP module code
stalabi1 Nov 1, 2024
19bb7af
Update 477-stp-bugfix-and-refactor.yaml
stalabi1 Nov 1, 2024
8772b49
Fix typo
stalabi1 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/477-stp-bugfix-and-refactor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- sonic_stp - Fix functionality to allow a value of 0 to be configured for the appropriate integer attributes and refactor module code(https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/477)
28 changes: 14 additions & 14 deletions plugins/module_utils/network/sonic/argspec/stp/stp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,34 +42,34 @@ def __init__(self, **kwargs):
'options': {
'global': {
'options': {
'bpdu_filter': {'default': False, 'type': 'bool'},
'bridge_priority': {'default': 32768, 'type': 'int'},
'bpdu_filter': {'type': 'bool'},
'bridge_priority': {'type': 'int'},
'disabled_vlans': {'elements': 'str', 'type': 'list'},
'enabled_protocol': {'choices': ['mst', 'pvst', 'rapid_pvst'], 'type': 'str'},
'fwd_delay': {'default': 15, 'type': 'int'},
'hello_time': {'default': 2, 'type': 'int'},
'loop_guard': {'default': False, 'type': 'bool'},
'max_age': {'default': 20, 'type': 'int'},
'portfast': {'default': False, 'type': 'bool'},
'fwd_delay': {'type': 'int'},
'hello_time': {'type': 'int'},
'loop_guard': {'type': 'bool'},
'max_age': {'type': 'int'},
'portfast': {'type': 'bool'},
'root_guard_timeout': {'type': 'int'}
},
'type': 'dict'
},
'interfaces': {
'elements': 'dict',
'options': {
'bpdu_filter': {'default': False, 'type': 'bool'},
'bpdu_guard': {'default': False, 'type': 'bool'},
'bpdu_filter': {'type': 'bool'},
'bpdu_guard': {'type': 'bool'},
'cost': {'type': 'int'},
'edge_port': {'default': False, 'type': 'bool'},
'edge_port': {'type': 'bool'},
'guard': {'choices': ['loop', 'root', 'none'], 'type': 'str'},
'intf_name': {'required': True, 'type': 'str'},
'link_type': {'choices': ['point-to-point', 'shared'], 'type': 'str'},
'port_priority': {'type': 'int'},
'portfast': {'default': False, 'type': 'bool'},
'shutdown': {'default': False, 'type': 'bool'},
'stp_enable': {'default': True, 'type': 'bool'},
'uplink_fast': {'default': False, 'type': 'bool'}
'portfast': {'type': 'bool'},
'shutdown': {'type': 'bool'},
'stp_enable': {'type': 'bool'},
'uplink_fast': {'type': 'bool'}
},
'type': 'list'
},
Expand Down
Loading
Loading