Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_info): add activedirectory module import #73

Conversation

gotit96
Copy link
Contributor

@gotit96 gotit96 commented Sep 25, 2023

SUMMARY

This proposed change, add explicit import of ActiveDirectory module in object_info.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

object_info

ADDITIONAL INFORMATION

This change allow this module to run on server with automatic import of modules disabled. And improve error message when ActiveDirectory module is missing.

@softwarefactory-project-zuul
Copy link

@gotit96 gotit96 marked this pull request as ready for review September 25, 2023 09:14
Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, can you expand on how module auto import can be disabled?

@jborean93 jborean93 merged commit 6a577ee into ansible-collections:main Sep 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants