Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert skip tests to xfail #15511

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from
Draft

Convert skip tests to xfail #15511

wants to merge 3 commits into from

Conversation

jessicamack
Copy link
Member

SUMMARY

xfail provides more useful data than just skipping the tests.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
ADDITIONAL INFORMATION

@jessicamack jessicamack marked this pull request as draft September 13, 2024 19:25
webknjaz
webknjaz approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, though I've found that it's a good idea to append links to GitHub issues or something like that in xfail reasons, so that people could trace the origin stories of each and criteria for removing them.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamack @webknjaz