Skip to content

Commit

Permalink
Improve speed faces are loaded and ids are computed (#3812)
Browse files Browse the repository at this point in the history
* Improve speed faces are loaded and ids are computed

* refactoring Modeler3D and Modeler2D classes and inheritance

* refactoring Modeler3D and Modeler2D classes and inheritance

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

* Update pyaedt/modeler/cad/Primitives.py

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Update pyaedt/modeler/cad/Primitives.py

Co-authored-by: Kathy Pippert <[email protected]>

* Add Split method modification

* Add docstring to create_region

* Fix codacy

---------

Co-authored-by: maxcapodi78 <Shark78>
Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
  • Loading branch information
4 people authored Oct 30, 2023
1 parent 853d374 commit d19dc46
Show file tree
Hide file tree
Showing 12 changed files with 5,463 additions and 5,453 deletions.
2 changes: 1 addition & 1 deletion _unittest/test_08_Primitives3D.py
Original file line number Diff line number Diff line change
Expand Up @@ -1770,7 +1770,7 @@ def test_85_insert_layoutcomponent(self):
self.aedtapp.solution_type = "Terminal"
comp = self.aedtapp.modeler.insert_layout_component(self.layout_component, name=None, parameter_mapping=False)
assert isinstance(comp, UserDefinedComponent)
assert len(self.aedtapp.modeler.modeler.user_defined_components[comp.name].parts) == 3
assert len(self.aedtapp.modeler.user_defined_components[comp.name].parts) == 3
comp2 = self.aedtapp.modeler.insert_layout_component(
self.layout_component, name="new_layout", parameter_mapping=True
)
Expand Down
4 changes: 2 additions & 2 deletions pyaedt/hfss.py
Original file line number Diff line number Diff line change
Expand Up @@ -5770,8 +5770,8 @@ def get_antenna_ffd_solution_data(
self.logger.info("Far field sphere %s is created.", setup_name)

component_name = None
if self.solution_type == "SBR+" and self.modeler.modeler.user_defined_component_names:
antenna = self.modeler.user_defined_components[self.modeler.modeler.user_defined_component_names[0]]
if self.solution_type == "SBR+" and self.modeler.user_defined_component_names:
antenna = self.modeler.user_defined_components[self.modeler.user_defined_component_names[0]]
if antenna.native_properties["Type"] == "Linked Antenna":
component_name = antenna.name

Expand Down
Loading

0 comments on commit d19dc46

Please sign in to comment.