Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core loss electrical steel #3829

Merged
merged 37 commits into from
Nov 23, 2023
Merged

Core loss electrical steel #3829

merged 37 commits into from
Nov 23, 2023

Conversation

gmalinve
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Oct 31, 2023 that may be closed by this pull request
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I left some comments on improvements in the dictionaries handling.

pyaedt/modules/Material.py Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/generic/DataHandlers.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3829 (0baae87) into main (69cbff1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3829      +/-   ##
==========================================
+ Coverage   81.26%   81.28%   +0.02%     
==========================================
  Files         182      182              
  Lines       62911    63008      +97     
==========================================
+ Hits        51126    51219      +93     
- Misses      11785    11789       +4     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Samuelopez-ansys Samuelopez-ansys merged commit 2a62fa5 into main Nov 23, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the core_loss_electrical_steel branch November 23, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coreloss vs frequency
5 participants