-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core loss electrical steel #3829
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
… core_loss_electrical_steel # Conflicts: # pyaedt/modules/Material.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
# Conflicts: # _unittest/test_03_Materials.py
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. I left some comments on improvements in the dictionaries handling.
… core_loss_electrical_steel
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
+ Coverage 81.26% 81.28% +0.02%
==========================================
Files 182 182
Lines 62911 63008 +97
==========================================
+ Hits 51126 51219 +93
- Misses 11785 11789 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
No description provided.