Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in disjoint_nets method due to a regression in the net_name setter #3897

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Fix bug in disjoint_nets method due to a regression in the net_name setter #3897

merged 6 commits into from
Nov 23, 2023

Conversation

maxcapodi78
Copy link
Collaborator

Fix #3895

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added edb bug Something isn't working labels Nov 21, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Merging #3897 (30ff41c) into main (e44a1cd) will decrease coverage by 0.04%.
Report is 6 commits behind head on main.
The diff coverage is 58.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3897      +/-   ##
==========================================
- Coverage   81.29%   81.25%   -0.04%     
==========================================
  Files         182      182              
  Lines       62819    62883      +64     
==========================================
+ Hits        51070    51098      +28     
- Misses      11749    11785      +36

Samuelopez-ansys
Samuelopez-ansys approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hui-zhou-a
hui-zhou-a approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amichel0205
amichel0205 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@amichel0205 amichel0205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful tests with 3 different test cases. Issue fixed.

@maxcapodi78 maxcapodi78 merged commit 3de28eb into main Nov 23, 2023
10 of 12 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_3895 branch November 23, 2023 10:47
@SMoraisAnsys SMoraisAnsys mentioned this pull request Nov 28, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amichel0205 amichel0205 amichel0205 approved these changes

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@hui-zhou-a hui-zhou-a hui-zhou-a approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug located in ayout_validation.disjoint_nets() function
4 participants
@maxcapodi78 @hui-zhou-a @Samuelopez-ansys @amichel0205