-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solder balls height control with simconfig #3905
Solder balls height control with simconfig #3905
Conversation
# Conflicts: # pyaedt/edb_core/edb_data/primitives_data.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3905 +/- ##
=======================================
Coverage 81.29% 81.30%
=======================================
Files 182 182
Lines 63022 63030 +8
=======================================
+ Hits 51234 51245 +11
+ Misses 11788 11785 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_simconfig' into solder_balls_height_control_with_simconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov seems to indicate that the modified method build_simulation_project
is not tested for dict
components. When I read the code, I feel like it should be done with your new test and json file. Can you double check that your test works fine ?
Adding custom solder balls height support with SImulatiomCnnfiguration class.