Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "DecadeCount" "OctaveCount" "ExponentialCount" in parametric sw… #3910

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

IreneWoyna
Copy link
Contributor

…eep, removed unit from "step"

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@IreneWoyna IreneWoyna linked an issue Nov 24, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Nov 24, 2023
@IreneWoyna
Copy link
Contributor Author

It seems that "LogScale" is actually not used at all and could be removed

    elif variation_type == "LogScale":
        sweep_range = "DEC {} {} {}".format(start_point, end_point, step)

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #3910 (541901d) into main (223399e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3910   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         182      182           
  Lines       63147    63151    +4     
=======================================
+ Hits        51372    51377    +5     
+ Misses      11775    11774    -1     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IreneWoyna Great implementation, but you need to add some unit test to pass the CodeCov:
image

It is not your fault, it was not covered before, but now you touched this part of the code and the bot detected it :) You just need to add these different sweeps in the unittest.

@gmalinve
Copy link
Contributor

@IreneWoyna I'd remove the LogScale and add unit test to cover all new cases.

@gmalinve gmalinve self-assigned this Dec 6, 2023
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 2811961 into main Dec 7, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_parametric_logscale branch December 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in parametrics.add when using variation_type="LogScale"
4 participants