Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial implementation of operator based construction of expressions #5307

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ansAFinney
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys
Copy link
Member

@ansAFinney did you check if this Pull request is compatible with this class?

https://github.com/ansys/pyaedt/blob/main/src/ansys/aedt/core/visualization/post/fields_calculator.py

In addition, pyaedt alias changed to ansys.aedt.core, so new code should be there.

Finally, next time you should create an issue and the community could help you with PyAEDT best practices, because right now, this can not be merged into the repository

@SMoraisAnsys
Copy link
Collaborator

Hi @ansAFinney and thanks for the contribution. It seems to be of great quality !
As mentioned by @Samuelopez-ansys it would have been nice of you to open an issue or a discussion before doing all those changes. The changes seem to be related / to intersect with a module that is already existing https://github.com/ansys/pyaedt/blob/main/src/ansys/aedt/core/visualization/post/fields_calculator.py

Could you please provide us some information on what you want to achieve with those changes, why are they required, why shouldn't this be integrated with the current code ?

@SMoraisAnsys
Copy link
Collaborator

Hi @ansAFinney, a tiny ping to get feedback :)

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft November 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants