Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Import nastran improvements #5364

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Oct 31, 2024

Added Support for CHEXA, PSHELL and MPC in import_nastran method
Pshell are used for Material assignment
MPC for Port assignment
The method is now also returning the dictionary of the objects so user can manipulate and grab information useful to setup and material assignment

maxcapodi78 added 2 commits October 31, 2024 11:05
Pshell are used for Material assignment
MPC for Port assignment
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (72dd3bd) to head (9cf2a40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5364   +/-   ##
=======================================
  Coverage   84.39%   84.40%           
=======================================
  Files         140      140           
  Lines       58503    58549   +46     
=======================================
+ Hits        49375    49419   +44     
- Misses       9128     9130    +2     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I like the idea of returning the dictionary. I left minor comments.
Btw, could you improve the code coverage of the PR ?

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 6, 2024 15:40
@Samuelopez-ansys Samuelopez-ansys merged commit c46eca8 into main Nov 6, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the import_nastran_improvements branch November 6, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants