-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Import nastran improvements #5364
Conversation
Pshell are used for Material assignment MPC for Port assignment
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5364 +/- ##
=======================================
Coverage 84.39% 84.40%
=======================================
Files 140 140
Lines 58503 58549 +46
=======================================
+ Hits 49375 49419 +44
- Misses 9128 9130 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, I like the idea of returning the dictionary. I left minor comments.
Btw, could you improve the code coverage of the PR ?
Co-authored-by: Sébastien Morais <[email protected]>
Added Support for CHEXA, PSHELL and MPC in import_nastran method
Pshell are used for Material assignment
MPC for Port assignment
The method is now also returning the dictionary of the objects so user can manipulate and grab information useful to setup and material assignment