Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: polygon doesn't update after expansion #880

Merged
merged 6 commits into from
Nov 5, 2024
Merged

FIX: polygon doesn't update after expansion #880

merged 6 commits into from
Nov 5, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Nov 1, 2024 •
edited
Loading

  • expand method from .net api create a new polygon. It needs to be set to the primitive.
  • only polygon can expand. Move expand method to EdbPolygon class
  • Remove uittest for Path
  • do not export padstack definition by default.

@hui-zhou-a hui-zhou-a added the grpc-transition Changes that need to be included in gRPC transition label Nov 1, 2024
@github-actions github-actions bot added the testing Anything related to testing label Nov 1, 2024
svandenb-dev
svandenb-dev approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit faf0332 into main Nov 5, 2024
29 checks passed
@hui-zhou-a hui-zhou-a deleted the fix-polygon-expand branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hui-zhou-a @svandenb-dev