Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add export gds comps xml function #881

Merged
merged 11 commits into from
Nov 8, 2024
Merged

FEAT: add export gds comps xml function #881

merged 11 commits into from
Nov 8, 2024

Conversation

felipeescastro
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the testing Anything related to testing label Nov 4, 2024
@felipeescastro felipeescastro enabled auto-merge (squash) November 4, 2024 15:46
svandenb-dev
svandenb-dev previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev added grpc-transition Changes that need to be included in gRPC transition and removed testing Anything related to testing labels Nov 7, 2024
SMoraisAnsys
SMoraisAnsys reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felipeescastro Could you see if the test isn't taking too long to run ? It seems that the time required to run the CICD (for tests) has doubled in this PR.

@github-actions github-actions bot added the testing Anything related to testing label Nov 8, 2024
@felipeescastro
Copy link
Collaborator Author

@felipeescastro Could you see if the test isn't taking too long to run ? It seems that the time required to run the CICD (for tests) has doubled in this PR.

@SMoraisAnsys I'm not sure. The code runs smoothly locally and the unittest I added is supposed to be as fast as any other test in the test file.

@felipeescastro felipeescastro merged commit 9cfe330 into main Nov 8, 2024
24 checks passed
@felipeescastro felipeescastro deleted the fecastro/export_gds_comps_xml branch November 8, 2024 14:22
@SMoraisAnsys
Copy link
Collaborator

@felipeescastro Could you see if the test isn't taking too long to run ? It seems that the time required to run the CICD (for tests) has doubled in this PR.

@SMoraisAnsys I'm not sure. The code runs smoothly locally and the unittest I added is supposed to be as fast as any other test in the test file.

Simon fixes the bug, have a look at his changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@svandenb-dev svandenb-dev svandenb-dev left review comments

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipeescastro @SMoraisAnsys @svandenb-dev