Upgrade to go 1.21, replace golang.org/x/exp/slices with slices #4688
Conversation
Signed-off-by: Tiscs <[email protected]>
|
I have already done this. It does not need a pr
…On Fri, Oct 11, 2024 at 03:33 Stephen Kitt ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#4688 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMDYUOOTDQRP7PF6YPDZ26LM5AVCNFSM6AAAAABNOUCLYGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRSGM3TSOBYGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
It’s just confusing because it’s done in https://github.com/antlr4-go/antlr but not in https://github.com/antlr/antlr4/tree/dev/runtime/Go/antlr/v4 and the former says it’s a copy of the latter. |
|
Yes, but it referee to the build and release. You only use tagged versions
…On Fri, Oct 11, 2024 at 05:49 Stephen Kitt ***@***.***> wrote:
I have already done this. It does not need a pr
It’s just confusing because it’s done in
https://github.com/antlr4-go/antlr but not in
https://github.com/antlr/antlr4/tree/dev/runtime/Go/antlr/v4 and the
former says it’s a copy of the latter.
—
Reply to this email directly, view it on GitHub
<#4688 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMHOCVQPLV6YRUTQH7LZ263LDAVCNFSM6AAAAABNOUCLYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGI2DKNZWGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
OK, sorry for the noise. |
I have previously created a PR in the antlr4-go/antlr project. but as mentioned in the project README.md, |
Upgrade to go 1.21 to use
slicespackage instead ofgolang.org/x/exp/slicespackage.In the antlr4-go/antlr project, the go version declared in go.mod is already 1.22.