Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 3145: get mkindex.py to list out test case files in subdirectories #3157

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fix for 3145: get mkindex.py to list out test case files in subdirectories #3157

merged 2 commits into from
Mar 1, 2023

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Feb 28, 2023

Fix for #3145

_scripts/mkindex.py script changes:

  • Changed os.libdir() to Path(), so example files in subdirectories are listed.
  • Added checks for ".errors" and ".tree" files, so they are not listed in lab.antlr.org as an input file to parse. Python 3.10 is now required.
  • Added code to replace backslashes in paths to forward slashes.
  • Added code to format json file, so we can read the results.

Grammars.json file:

  • A number of grammars were not listed, start symbols wrong, and otherwise new test file examples added over the last few months to the repo. I updated the grammars.json file to support the current version of the "Antlr lab" running at lab.antlr.org.

To do:

…s in subdirectories. Add in check for ".errors" and ".tree" files so they are not included. Make sure if run on Windows that backslashes in path are renamed to forward slashes for Linux. Provide minimal formatting so one can read the results.
@kaby76 kaby76 marked this pull request as draft February 28, 2023 11:42
@kaby76
Copy link
Contributor Author

kaby76 commented Feb 28, 2023

Path names should be relative to the examples directory. It's currently relative to the root directory. It should not.

@kaby76 kaby76 marked this pull request as ready for review February 28, 2023 12:40
@teverett
Copy link
Member

teverett commented Mar 1, 2023

@kaby76 thanks!

@teverett teverett merged commit 00dd84a into antlr:master Mar 1, 2023
@parrt
Copy link
Member

parrt commented Mar 1, 2023

#2866 should be closed.

Done.

Regarding the access token... I guess that's something I need to feed to my server when I start it up? Are you sure there's no way I can just download via regular http? This is friction to my world and I'm already barely hanging on in terms of my workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants