feat: Add catalog/explorer dropdown to anvil portal header (#2796) #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
force-pushed
the
fran/2796-header
branch
from
511f262
to
4f1a602
Compare
frano-m
commented
Nov 14, 2023
| @@ -48,7 +48,7 @@ const config: SiteConfig = { | |||
| label: "Explorer", | |||
| }), | |||
| target: ANCHOR_TARGET.BLANK, | |||
| url: `${EXPLORER_URL}/datasets`, | |||
| url: `${EXPLORER_URL}/explore/datasets`, | |||
There was a problem hiding this comment.
Fixed PROD explore URL for next.
frano-m
commented
Nov 14, 2023
| import { EnvironmentUrl } from "./environment/environment-url.model"; | ||
| import { getCurrentEnvironment } from "./environment/environment.service"; | ||
|
|
||
| const PROD_ENV = ["ANVIL-PROD", "MASTER", "PROD"]; |
There was a problem hiding this comment.
@NoopDog the PROD_ENV array of potential PROD environments is an attempt to catch all possible PROD env that require the explore URL to point to PROD....
NoopDog
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2796.