fix: publication and workspace cards on homepage are missing the rel="noopener noreferrer"attribute (#3336) #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
commented
Nov 8, 2024
There was a problem hiding this comment.
Added noopener noreferrer to Datasets.
frano-m
commented
Nov 8, 2024
| @@ -35,7 +36,10 @@ export const SectionDatasets = ({ | |||
| <NLink href={CONSORTIA_ROADMAP} legacyBehavior passHref> | |||
| <ButtonSecondary href="passHref">Consortia Roadmap</ButtonSecondary> | |||
| </NLink> | |||
| <ButtonSecondary href={`${portalURL}${EXPLORE_DATASETS}`}> | |||
| <ButtonSecondary | |||
There was a problem hiding this comment.
Added noopener noreferrer to Explore Datasets.
frano-m
commented
Nov 8, 2024
| @@ -21,6 +24,7 @@ export const SectionPublications = (): JSX.Element => { | |||
| <Button | |||
| color="primary" | |||
| href={ADD_PUBLICATION} | |||
| rel={REL_ATTRIBUTE.NO_OPENER_NO_REFERRER} | |||
There was a problem hiding this comment.
Added noopener noreferrer to "Add Publication" link.
frano-m
commented
Nov 8, 2024
| @@ -29,6 +32,7 @@ export const Contribute = ({ slug }: ContributeProps): JSX.Element => { | |||
| disabled={slug?.length === 0} | |||
| href={getGitHubUrl(slug)} | |||
| startIcon={<CodePullRequestIcon color="inkLight" />} | |||
| rel={REL_ATTRIBUTE.NO_OPENER_NO_REFERRER} | |||
There was a problem hiding this comment.
Added noopener noreferrer to "Make a contribution" link.
frano-m
commented
Nov 8, 2024
frano-m
commented
Nov 8, 2024
| import { Button as PrimaryButton } from "./button.styles"; | ||
|
|
||
| export const Button = (): JSX.Element => { | ||
| return ( | ||
| <PrimaryButton | ||
| color="primary" | ||
| href="https://github.com/anvilproject/anvil-portal/issues/new/?template=add-a-publication.md" | ||
| rel={REL_ATTRIBUTE.NO_OPENER_NO_REFERRER} |
There was a problem hiding this comment.
Added noopener noreferrer to "Add Your Publication".
frano-m
force-pushed
the
fran/3336-external-links
branch
from
ebb2f06
to
a5bf3ab
Compare
added 2 commits
November 8, 2024 18:29
…"noopener noreferrer"attribute (#3336)
frano-m
force-pushed
the
fran/3336-external-links
branch
from
a5bf3ab
to
ba8ec32
Compare
NoopDog
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3336.