Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: transaction performance tracking -- streamer stage (backport of #257) #598

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 5, 2024

Problem

Enable the system to track transaction processing performance through various stage based on probability. This is the resubmit of the PR solana-labs#34789 against Agave for the first part: streamer only to reduce PR size

Summary of Changes

Based on the https://docs.google.com/document/d/1ig1rC0dk-ddi33JIqG9EZ4ZSq9xAJpT9fQTPaZFi_vw/edit.
We use a randomly generated 12 bits integer as a mask to match the transaction's signature. If it is matched, we mark the packet for tracking for performance in the Meta's mask. This is used efficiently down stream without doing mask matching. For these matched packets we report processing time for: fetch, sigverify and banking stage.


This is an automatic backport of pull request #257 done by [Mergify](https://mergify.com).

* transaction performance tracking -- streamer stage

(cherry picked from commit 2b03910)

# Conflicts:
#	Cargo.toml
#	streamer/src/nonblocking/quic.rs
#	streamer/src/quic.rs
@mergify mergify bot added the conflicts label Apr 5, 2024
Copy link
Author

mergify bot commented Apr 5, 2024

Cherry-pick of 2b03910 has failed:

On branch mergify/bp/v1.17/pr-257
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 2b0391049d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.lock
	modified:   programs/sbf/Cargo.lock
	modified:   sdk/src/packet.rs
	modified:   streamer/Cargo.toml
	new file:   transaction-metrics-tracker/Cargo.toml
	new file:   transaction-metrics-tracker/src/lib.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.toml
	both modified:   streamer/src/nonblocking/quic.rs
	both modified:   streamer/src/quic.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Changes appear identical to the v1.18 backport, so approving with the same reasons/caveats as noted there: #597 (review)

@steviez
Copy link

steviez commented Jul 2, 2024

With MNB on v1.18, v1.17 is EOL so closing out this PR

@steviez steviez closed this Jul 2, 2024
@steviez steviez deleted the mergify/bp/v1.17/pr-257 branch July 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants