-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign In With Solana #783
Sign In With Solana #783
Conversation
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
9436299
to
dac47dc
Compare
@jordansexton Hello, can you please confirm that the If I were to guess where the problem might have occurred from commit history here I can see you thoroughly tested everything but in 9cbc406 switched versions and the I did two tests one with cloned master of this repo and also installing the necessary packages into my nextjs application with everything up to date including chrome and all extensions. I also did the same for most of the examples here, I think I am doing everything right but the Below is screenshot where you can see disabled sign in button. Even if I make the button clickable it fails. Could you please help me I have spend few hours on this without any progress while trying to make this feature work in application already running in production where we started encountering sporadic problems with auth. State in wallet after nextjs transitions sometimes doesn't make sense or |
@kolpav it's not in the production build of Phantom yet. You can test it in the demo by selecting the Unsafe Burner wallet. I'll follow up here when it's released in Phantom with an actual integration guide. |
To further explain this, the |
@jordansexton Than you for getting back, I think now I understand how the release process works and why the method is available but not supported yet. Is there rough estimate when its going to land in phantom? I'll test my current dev implementation with Unsafe Burner in the meantime and wait till its going to be ready, really like where this is going UX/DX wise. |
@bfriel or @0xproflupin may know about the release timeline. |
This is going out in Phantom's next extension release! No set ETA but shooting for within the next ~2 weeks. Will make an announcement when we are closer to launch. |
hey @jordansexton, thanks for doing all this – really awesome stuff. Just wanted to clarify – seems like whenever dApps want to trigger the SIWS experience, they should be calling |
hey @alex-fung, web3auth's docs do not use the new SIWS spec. You can use it still, but it won't make use of the new feature which clubs the connect + signMessage flows. |
Thank you @0xproflupin! |
This PR adds a
signIn
method to adapters.This method uses the Wallet Standard
solana:signIn
feature from anza-xyz/wallet-standard#12Some tasks:
@solana/wallet-standard
with SIWSsignIn
method, types, and abstract adapter to base packagesignIn
method to React contextsignIn
to Unsafe Burner adapter for testingsignIn
verifySignMessage
andverifySignIn
functionstweetnacl
with@noble/crypto
packages@solana/wallet-adapter
with SIWS@solana/wallet-standard-wallet-adapter-base
to use published alpha of@solana/wallet-adapter
StandardWalletAdapter
to supportsignIn
@solana/wallet-standard-wallet-adapter-base
@solana/wallet-standard-wallet-adapter-base
signIn
to be used instead ofconnect
in connect and autoConnect behaviors@solana/wallet-standard
with SIWS@solana/wallet-adapter
to use production version of@solana/wallet-standard
with SIWS@solana/wallet-adapter
with SIWS@solana/wallet-standard
to use production version of@solana/wallet-adapter
with SIWS@solana/wallet-standard