Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35943: [Dev] Ensure link issue works when PR body is empty #36460

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 4, 2023

Rationale for this change

Fix a bug when PR body is empty and Dev workflow fails.

What changes are included in this PR?

Ensure the link issue comment works in case of description being empty.

Are these changes tested?

I have tested it on my fork here: raulcd#81

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

⚠️ GitHub issue #35943 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 4, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

.github/workflows/dev_pr/link.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 4, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jul 5, 2023
@raulcd
Copy link
Member Author

raulcd commented Jul 5, 2023

👍

@raulcd raulcd merged commit 0df414e into apache:main Jul 5, 2023
6 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label Jul 5, 2023
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 0df414e1.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Dev PR workflow fails to add link to GH issue if the body of PR is empty
2 participants