AVRO-3790 Provide namespace on UnknownSchemaError raise #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an UnknownSchemaError is raised for a nested type that should inherit its parent namespace, the default_namespace information is lost when rescuing this exception. This prevents users of the library to use the raised exception to load the missing schema that may be defined in a separate file fore readability when handling large schema files.
martin-g
approved these changes
Jul 31, 2023
|
HI @martin-g, thanks for the approval! |
tjwp
approved these changes
Aug 8, 2023
tjwp
pushed a commit
that referenced
this pull request
Aug 8, 2023
|
I've merged and also cherry-picked to the 1.11 branch. |
|
Hi @tjwp |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If an UnknownSchemaError is raised for a nested type that should inherit its parent namespace, the default_namespace information is lost when rescuing this exception.
This prevents users of the library to use the raised exception to load the missing schema that may be defined in a separate file fore readability when handling large schema files.
Verifying this change
This is a simple addition of information when raising an exception on encountering an unknown schema reference. The existing unit test has been updated to make sure the correct information is added to the exception.
Documentation