AVRO-4078: [Java] Add the test classes as test case #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
| public class FullName extends SpecificRecordBase implements SpecificRecord { | ||
| private static final long serialVersionUID = 4560514203639509981L; | ||
| public static final Schema SCHEMA$ = (new Schema.Parser()).parse( | ||
| "{\"type\":\"record\",\"name\":\"FullName\",\"namespace\":\"com.example\",\"fields\":[{\"name\":\"first\",\"type\":{\"type\":\"string\",\"avro.java.string\":\"String\"}},{\"name\":\"last\",\"type\":{\"type\":\"string\",\"avro.java.string\":\"String\"}}]}"); |
There was a problem hiding this comment.
can you change the namespace here from com.example to org.apache.avro
| @Test | ||
| public void testClassLoad() { | ||
| System.err.println(FULLNAME_SCHEMA); | ||
| System.err.println(SpecificData.get().getClass(FULLNAME_SCHEMA)); |
There was a problem hiding this comment.
can you please add assertNotNull(SpecificData.get().getClass(FULLNAME_SCHEMA)) to make sure that the test only passes when its successfully able to load the class.
Right now the test may/will pass even when it gets a null response from SpecificData.get().getClass(FULLNAME_SCHEMA)
There was a problem hiding this comment.
Done!
This shows the problem in the test case too!
The static initialization of FullName READER$ and WRITER$ fields lead to a hang!
Now the test hangs while trying to initialize the static field READER$ and WRITER$ Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
diff --git i/lang/java/avro/src/main/java/org/apache/avro/util/ClassUtils.java w/lang/java/avro/src/main/java/org/apache/avro/util/ClassUtils.java
index dad59a551..e042d7b95 100644
--- i/lang/java/avro/src/main/java/org/apache/avro/util/ClassUtils.java
+++ w/lang/java/avro/src/main/java/org/apache/avro/util/ClassUtils.java
@@ -92,7 +92,7 @@ public class ClassUtils {
Class<?> c = null;
if (classLoader != null && className != null) {
try {
- c = Class.forName(className, true, classLoader);
+ c = Class.forName(className, false, classLoader);
} catch (ClassNotFoundException e) {
// Ignore and return null
}
this fixes the problem and all other tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
What is the purpose of the change
The reproducer fails against Avro 1.11.4 but passes against 1.12.0.
The test case passes against 1.11.5-SNAPSHOT and 1.13.0-SNAPSHOT.
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation