add null value edge case unit test for Row.equals (#27614)

apache · Jul 22, 2023 · 30c324a · 30c324a
1 parent 0510dd7
commit 30c324a
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java
@@ -405,7 +405,7 @@ public void testCreateAndCompareNullMap() {
   }
 
   @Test
-  public void testCreateMapWithNullValue() {
+  public void testCreateAndCompareMapWithNullValue() {
     Map<Integer, String> data = new HashMap();
     data.put(1, "value1");
     data.put(2, "value2");
@@ -416,6 +416,25 @@ public void testCreateMapWithNullValue() {
             .collect(toSchema());
     Row row = Row.withSchema(type).addValue(data).build();
     assertEquals(data, row.getMap("map"));
+
+    Map<Integer, String> onlyNullValueData = new HashMap();
+    onlyNullValueData.put(1, null);
+    onlyNullValueData.put(2, null);
+
+    Map<Integer, String> otherOnlyNullValueData = new HashMap();
+    otherOnlyNullValueData.put(3, null);
+    otherOnlyNullValueData.put(4, null);
+
+    Row otherNonNullValue =
+        Row.withSchema(type)
+            .addValue(ImmutableMap.of(1, "value1", 2, "value2", 3, "value3", 4, "value4"))
+            .build();
+    Row otherNullValue = Row.withSchema(type).addValue(data).build();
+    Row onlyNullValue = Row.withSchema(type).addValue(onlyNullValueData).build();
+    Row otherOnlyNullValue = Row.withSchema(type).addValue(otherOnlyNullValueData).build();
+    assertNotEquals(otherNonNullValue, row);
+    assertEquals(otherNullValue, row);
+    assertNotEquals(onlyNullValue, otherOnlyNullValue);
   }
 
   @Test