Skip to content

Commit

Permalink
Fix Python test auth (#31850)
Browse files Browse the repository at this point in the history
* Fix Python test auth

* Replace more places setup-gcloud@v0 -> auth@v1

* add setup cloud

* Revert change on build_wheels
  • Loading branch information
Abacn authored Jul 11, 2024
1 parent 50a3403 commit 441840a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 16 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/build_runner_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }}
- name: Authenticate on GCP
if: github.ref == 'refs/heads/master'
uses: google-github-actions/setup-gcloud@v0
uses: google-github-actions/auth@v1
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
credentials_json: ${{ secrets.GCP_SA_KEY }}
project_id: ${{ secrets.GCP_PROJECT_ID }}
export_default_credentials: true
- name: GCloud Docker credential helper
run: |
gcloud auth configure-docker ${{env.docker_registry}}
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/java_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,10 @@ jobs:
java-version: 11
go-version: default
- name: Authenticate on GCP
uses: google-github-actions/setup-gcloud@v0
uses: google-github-actions/auth@v1
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
credentials_json: ${{ secrets.GCP_SA_KEY }}
project_id: ${{ secrets.GCP_PROJECT_ID }}
export_default_credentials: true
- name: Run WordCount
uses: ./.github/actions/gradle-command-self-hosted-action
with:
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,11 @@ jobs:
name: python_sdk_source
path: apache-beam-source
- name: Authenticate on GCP
uses: google-github-actions/setup-gcloud@v0
id: auth
uses: google-github-actions/auth@v1
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
credentials_json: ${{ secrets.GCP_SA_KEY }}
project_id: ${{ secrets.GCP_PROJECT_ID }}
export_default_credentials: true
- name: Install requirements
working-directory: ./sdks/python
run: pip install setuptools --upgrade && pip install -e ".[gcp]"
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/typescript_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,10 @@ jobs:
pip install 'pandas>=1.0,<1.5'
pip install -e ".[gcp]"
- name: Authenticate on GCP
uses: google-github-actions/setup-gcloud@v0
uses: google-github-actions/auth@v1
with:
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
service_account_key: ${{ secrets.GCP_SA_KEY }}
credentials_json: ${{ secrets.GCP_SA_KEY }}
project_id: ${{ secrets.GCP_PROJECT_ID }}
export_default_credentials: true
- run: npm ci
working-directory: ./sdks/typescript
- run: npm run build
Expand Down

0 comments on commit 441840a

Please sign in to comment.