Skip to content

Commit

Permalink
[Go] Update Go version used by Beam repo to go1.23.1 (#32575)
Browse files Browse the repository at this point in the history
* Update Go version used by Beam repo.

* update release docker in docker container

* update CHANGES.md with this note

---------

Co-authored-by: lostluck <[email protected]>
  • Loading branch information
lostluck and lostluck authored Sep 30, 2024
1 parent 9487927 commit 7da6c89
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"SPARK_VERSIONS": ["2", "3"]
},
"GoTestProperties": {
"SUPPORTED_VERSIONS": ["1.22"]
"SUPPORTED_VERSIONS": ["1.23"]
}
}
2 changes: 1 addition & 1 deletion .github/actions/setup-environment-action/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@ runs:
if: ${{ inputs.go-version != '' }}
uses: actions/setup-go@v5
with:
go-version: ${{ inputs.go-version == 'default' && '1.22' || inputs.go-version }} # never set patch, to get latest patch releases.
go-version: ${{ inputs.go-version == 'default' && '1.23' || inputs.go-version }} # never set patch, to get latest patch releases.
cache-dependency-path: $${{ inputs.disable-cache && '' || 'sdks/go.sum' }}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RUN curl -OL https://nodejs.org/dist/v18.16.0/node-v18.16.0-linux-x64.tar.xz &&
mv /usr/local/node-v18.16.0-linux-x64 /usr/local/node
ENV PATH="${PATH}:/usr/local/node/bin"
#Install Go
ARG go_version=1.22.5
ARG go_version=1.23.1
RUN curl -OL https://go.dev/dl/go${go_version}.linux-amd64.tar.gz && \
tar -C /usr/local -xzf go${go_version}.linux-amd64.tar.gz && \
rm go${go_version}.linux-amd64.tar.gz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_release_candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ jobs:
fi
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- name: Import GPG key
id: import_gpg
uses: crazy-max/ghaction-import-gpg@111c56156bcc6918c056dbef52164cfa583dc549
Expand Down
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
* Dataflow worker can install packages from Google Artifact Registry Python repositories (Python) ([#32123](https://github.com/apache/beam/issues/32123)).
* Added support for Zstd codec in SerializableAvroCodecFactory (Java) ([#32349](https://github.com/apache/beam/issues/32349))
* Added support for using vLLM in the RunInference transform (Python) ([#32528](https://github.com/apache/beam/issues/32528))
* Prism release binaries and container bootloaders are now being built with the latest Go 1.23 patch. ([#32575](https://github.com/apache/beam/pull/32575))
* Prism
* Prism now supports Bundle Finalization. ([#32425](https://github.com/apache/beam/pull/32425))
* Significantly improved performance of Kafka IO reads that enable [commitOffsetsInFinalize](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/kafka/KafkaIO.Read.html#commitOffsetsInFinalize--) by removing the data reshuffle from SDF implementation. ([#31682](https://github.com/apache/beam/pull/31682)).

## Breaking Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2221,7 +2221,7 @@ class BeamModulePlugin implements Plugin<Project> {

// This sets the whole project Go version.
// The latest stable Go version can be checked at https://go.dev/dl/
project.ext.goVersion = "go1.22.5"
project.ext.goVersion = "go1.23.1"

// Minor TODO: Figure out if we can pull out the GOCMD env variable after goPrepare script
// completion, and avoid this GOBIN substitution.
Expand Down
2 changes: 1 addition & 1 deletion dev-support/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ RUN pip3 install distlib==0.3.1 yapf==0.29.0 pytest
###
# Install Go
###
ENV DOWNLOAD_GO_VERSION=1.22.5
ENV DOWNLOAD_GO_VERSION=1.23.1
RUN wget https://golang.org/dl/go${DOWNLOAD_GO_VERSION}.linux-amd64.tar.gz && \
tar -C /usr/local -xzf go${DOWNLOAD_GO_VERSION}.linux-amd64.tar.gz
ENV GOROOT /usr/local/go
Expand Down
4 changes: 2 additions & 2 deletions release/src/main/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ RUN curl https://pyenv.run | bash && \

# Install a Go version >= 1.16 so we can bootstrap higher
# Go versions
RUN wget https://golang.org/dl/go1.17.linux-amd64.tar.gz && \
tar -zxvf go1.17.linux-amd64.tar.gz -C /usr/local/ && \
RUN wget https://golang.org/dl/go1.23.1.linux-amd64.tar.gz && \
tar -zxvf go1.23.1.linux-amd64.tar.gz -C /usr/local/ && \
echo "export PATH=/usr/local/go/bin:${PATH}" | tee /etc/profile.d/go.sh && \
chmod a+x "/etc/profile.d/go.sh" && \
source "/etc/profile.d/go.sh"
Expand Down
2 changes: 1 addition & 1 deletion sdks/go/run_with_go_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ set -e
#
# This variable is also used as the execution command downscript.
# The list of downloadable versions are at https://go.dev/dl/
GOVERS=go1.22.5
GOVERS=go1.23.1

if ! command -v go &> /dev/null
then
Expand Down

0 comments on commit 7da6c89

Please sign in to comment.