-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove avro dependency from runners/core-construction-java
- Loading branch information
1 parent
ea68a45
commit 95d6ec0
Showing
11 changed files
with
133 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
.../java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/package-info.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| /** | ||
| * Defines {@link org.apache.beam.sdk.schemas.Schema} and other classes for representing schema'd | ||
| * data in a {@link org.apache.beam.sdk.Pipeline} using Apache Avro. | ||
| */ | ||
| @DefaultAnnotation(NonNull.class) | ||
| package org.apache.beam.sdk.extensions.avro; | ||
|
|
||
| import edu.umd.cs.findbugs.annotations.DefaultAnnotation; | ||
| import org.checkerframework.checker.nullness.qual.NonNull; |
59 changes: 59 additions & 0 deletions
59
...ions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/AvroCoderTranslationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.extensions.avro; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.equalTo; | ||
|
|
||
| import org.apache.avro.SchemaBuilder; | ||
| import org.apache.beam.model.pipeline.v1.RunnerApi; | ||
| import org.apache.beam.model.pipeline.v1.RunnerApi.Components; | ||
| import org.apache.beam.runners.core.construction.CoderTranslation; | ||
| import org.apache.beam.runners.core.construction.CoderTranslation.TranslationContext; | ||
| import org.apache.beam.runners.core.construction.Environments; | ||
| import org.apache.beam.runners.core.construction.RehydratedComponents; | ||
| import org.apache.beam.runners.core.construction.SdkComponents; | ||
| import org.apache.beam.sdk.coders.Coder; | ||
| import org.apache.beam.sdk.extensions.avro.coders.AvroCoder; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| /** Tests for {@link AvroCoder} translation. */ | ||
| @SuppressWarnings({ | ||
| "rawtypes", // TODO(https://github.com/apache/beam/issues/20447) | ||
| }) | ||
| @RunWith(JUnit4.class) | ||
| public class AvroCoderTranslationTest { | ||
| /** Tests round-trip coder encodings for both known and unknown {@link Coder coders}. */ | ||
| @Test | ||
| public void toAndFromProto() throws Exception { | ||
| Coder<?> coder = AvroCoder.of(SchemaBuilder.record("record").fields().endRecord()); | ||
| SdkComponents sdkComponents = SdkComponents.create(); | ||
| sdkComponents.registerEnvironment(Environments.createDockerEnvironment("java")); | ||
| RunnerApi.Coder coderProto = CoderTranslation.toProto(coder, sdkComponents); | ||
|
|
||
| Components encodedComponents = sdkComponents.toComponents(); | ||
| Coder<?> decodedCoder = | ||
| CoderTranslation.fromProto( | ||
| coderProto, | ||
| RehydratedComponents.forComponents(encodedComponents), | ||
| TranslationContext.DEFAULT); | ||
| assertThat(decodedCoder, equalTo(coder)); | ||
| } | ||
| } |