Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method… #25843

Merged
merged 2 commits into from
May 31, 2023
Merged

fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method… #25843

merged 2 commits into from
May 31, 2023

Conversation

bigduu
Copy link
Contributor

@bigduu bigduu commented Mar 14, 2023 •
edited
Loading

Please add a meaningful description for your change here
The detail in the issue
#25841

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Mar 14, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles

@kennknowles
Copy link
Member

Run Java PreCommit

@kennknowles
Copy link
Member

Run Java_GCP_IO_Direct PreCommit

@kennknowles
Copy link
Member

Run Java_Pulsar_IO_Direct PreCommit

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb

robertwb
robertwb approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@robertwb
Copy link
Contributor

Run Spotless PreCommit

@robertwb
Copy link
Contributor

Run Java PreCommit

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Reminder, please take a look at this pr: @Abacn

Abacn
Abacn requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java PreCommit failure related: :sdks:java:core:spotbugsMain:

FS: Format string should use %n rather than \n in org.apache.beam.sdk.transforms.ParDo.validateStateApplicableForInput(PCollection)

See https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/6025/spotbugs/source.76f51a95-fa8a-475b-9853-ea72a5d9ab6f/#448

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@Abacn Abacn merged commit fb1683d into apache:master May 31, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@bigduu @cushon
fixes:apache#25841 Improve-error-messages-for-the-validateStateApplic…
7b19153 
…ableForInput-method… (apache#25843)

* Improve-error-messages-for-the-validateStateApplicableForInput-method-in-ParDO-so-that-they-are-more-helpful

* Update sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn requested changes

@robertwb robertwb robertwb approved these changes

Assignees
No one assigned
Labels
java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigduu @kennknowles @robertwb @Abacn