Add ValidatesContainer tests with installing release candidates(RCs) #26156
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report
@@ Coverage Diff @@
## master #26156 +/- ##
==========================================
+ Coverage 71.21% 71.36% +0.14%
==========================================
Files 787 783 -4
Lines 103330 102982 -348
==========================================
- Hits 73588 73488 -100
+ Misses 28246 28011 -235
+ Partials 1496 1483 -13
Flags with carried forward coverage won't be shown. Click here to find out more. see 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Run Python RC Dataflow ValidatesContainer |
|
Looks like there are other failures due to this PR. I will solve them. Changing this PR to draft until then. Update: Fix is easy. Will commit once the |
|
For reference: Successful build: https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_with_RC_PR/1/ |
|
cc: @tvalentyn |
|
I see failed seedjob on this PR: https://ci-beam.apache.org/job/beam_SeedJob/11381/console with "ERROR: Couldn't find any revision to build." may need to rebase the latest master onto it to run, probably due to a force push on master earlier today? |
AnandInguva
force-pushed
the
rc-validate-container
branch
from
fc90916
to
43efb82
Compare
sdks/python/container/Dockerfile
Outdated
| @@ -70,9 +70,11 @@ RUN ccache --set-config=sloppiness=file_macro && ccache --set-config=hash_dir=fa | |||
| #### | |||
| # Install Apache Beam SDK. Use --no-deps and pip check to verify that all | |||
| # necessary dependencies are specified in base_image_requirements.txt. | |||
| # use ARG pip_extra_options to install release candidates(RCs) of Beam' | |||
There was a problem hiding this comment.
again, you are making an assumption that this file can't reason about. one may supply pip extra options for any purpose.
There was a problem hiding this comment.
yes. previously the purpose was to add only --pre but since we can add any flag to pip installation, i changed the wording.
|
retest this please |
|
Run Python RC Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesContainer |
|
the container is built by using RCs. |
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
|
Run Python RC Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesContainer |
| project.ext.pythonVersion = project.hasProperty('pythonVersion') ? | ||
| project.pythonVersion : '3.8' | ||
| project.pythonVersion : '3.11' |
There was a problem hiding this comment.
Looks like this change is non-trivial and need some changes. I will make a separate PR for this
|
Run Python Dataflow ValidatesContainer |
|
Run PythonDocker PreCommit |
|
@tvalentyn Can we squash/merge this? |
|
nice. Thanks! |
Part 2 of #25668
Adds a Jenkins suite that run
ValidatesContainersuite with pre-released Beam's dependencies. This could help catch regressions/breaking changes sooner than later.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.