Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GH workflow for testing conflicts in Beam's dependencies. #26170

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Apr 7, 2023

This workflow will be used to find out if there are any dependency conflicts when dependencies in sdks/python/setup.py are updated and not updated in the container base_image_requirements at sdks/python/container/py**/base_image_requirements.txt.

If this workflow fails, contributor would need to generate requirements to resolve any dependency conflicts.

Part of #25668


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #26170 (9698aaa) into master (a6e4afc) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9698aaa differs from pull request most recent head 25491f3. Consider uploading reports for the commit 25491f3 to get more accurate results

@@            Coverage Diff             @@
##           master   #26170      +/-   ##
==========================================
- Coverage   71.18%   71.16%   -0.02%     
==========================================
  Files         787      787              
  Lines      103288   103311      +23     
==========================================
- Hits        73523    73521       -2     
- Misses      28282    28302      +20     
- Partials     1483     1488       +5     
Flag Coverage Δ
python 79.84% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva
Copy link
Contributor Author

Run Python_Coverage PreCommit

@AnandInguva AnandInguva marked this pull request as ready for review April 10, 2023 14:59
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva AnandInguva changed the title Add a GH workflow for Beam's dependencies. Add a GH workflow for testing conflicts in Beam's dependencies. Apr 11, 2023
@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @pabloem @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - we can monitor this job over the next few days to make sure its behaving correctly once merged as well.

@damccorm damccorm merged commit 37efc5c into apache:master Apr 21, 2023
tvalentyn pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants