Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable FIrestore integration test in Dataflow PostCommits" #26584

Closed
wants to merge 1 commit into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 8, 2023

Reverts #26060

Fixes #25851

Fix from gcp should be rolled out

@Abacn
Copy link
Contributor Author

Abacn commented May 8, 2023

Run Java PostCommit

@Abacn
Copy link
Contributor Author

Abacn commented May 8, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented May 8, 2023

Java PostCommit failing runrelated.

It start failing on May 4, 5 PM GMT, but then at May 5, 5 PM GMT there is a successful run, then permared since then. No obvious code change at that time. Is it some breaking change at gcp side?

image

@Abacn
Copy link
Contributor Author

Abacn commented May 8, 2023

Now most disabled tests passed again

Class	Duration	Fail	(diff)	Skip	(diff)	Pass	(diff)	Total	(diff)
FirestoreV1IT	46 min	1	+1	0		6	+6	7	+7

but there is still one test failing the same reason as it was before:

java.lang.RuntimeException: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Invalid request routing header collection_id=a&parent=projects/apache-beam-testing/databases/firestoredb/documents/beam/IT/2023-05-08T14:24:05.343/FirestoreV1IT/test/listDocuments. Please fill in the request header with format x-goog-request-params:project_id=apache-beam-testing&database_id=firestoredb
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:92)

See https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/174/testReport/junit/org.apache.beam.sdk.io.gcp.firestore.it/FirestoreV1IT/listDocuments/ for full traceback.

@Abacn
Copy link
Contributor Author

Abacn commented May 16, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented May 16, 2023

Run Java PostCommit

@Abacn
Copy link
Contributor Author

Abacn commented May 16, 2023

Run Java_Examples_Dataflow_Java11 PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented May 17, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented May 17, 2023

Reopen

@Abacn Abacn closed this May 17, 2023
@Abacn Abacn deleted the revert-26060-disablefirestoreioit branch May 17, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Firestore integration tests failing affecting GCPIO_PreCommit, DataflowPostCommit V1 and V2
1 participant