Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CombineGlobally with GlobalWindows #26922

Merged
merged 15 commits into from
Jul 7, 2023
Merged

Fix CombineGlobally with GlobalWindows #26922

merged 15 commits into from
Jul 7, 2023

Conversation

liferoad
Copy link
Collaborator

Address #24683

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@liferoad
Copy link
Collaborator Author

@tvalentyn From my two tests, I do not see any problem with CombineGlobally to process multiple windows as long as each window produces one value since it is required by CombineGlobally. I might misunderstand the issue.

@liferoad liferoad changed the title add tests Fix inject_default in CombineGlobally Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #26922 (1aa9a30) into master (a6b147a) will decrease coverage by 0.48%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #26922      +/-   ##
==========================================
- Coverage   71.48%   71.01%   -0.48%     
==========================================
  Files         858      858              
  Lines      104750   104019     -731     
==========================================
- Hits        74885    73864    -1021     
- Misses      28318    28606     +288     
- Partials     1547     1549       +2
Flag Coverage Δ
python 80.30% <75.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 93.16% <75.00%> (+1.21%) ⬆️

... and 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liferoad liferoad changed the title Fix inject_default in CombineGlobally Fix CombineGlobally with GlobalWindows Jun 9, 2023
@liferoad liferoad marked this pull request as ready for review June 9, 2023 23:30
@liferoad liferoad requested a review from robertwb June 10, 2023 01:54
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @tvalentyn

@liferoad liferoad requested a review from tvalentyn June 28, 2023 20:38
@tvalentyn
Copy link
Contributor

@liferoad lmk if you'd like to merge or wait to give @robertwb another chance to TAL.

@liferoad
Copy link
Collaborator Author

@liferoad lmk if you'd like to merge or wait to give @robertwb another chance to TAL.

Let us wait for him.

robertwb
robertwb approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to squash before you merge.

sdks/python/apache_beam/transforms/combine_globally_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/transforms/core.py Outdated Show resolved Hide resolved
@robertwb
Copy link
Contributor

robertwb commented Jul 7, 2023

LGTM

@robertwb robertwb merged commit 4ba5e43 into apache:master Jul 7, 2023
@liferoad liferoad mentioned this pull request Jul 7, 2023
Closed
15 tasks
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
@liferoad @aleksandr-dudko
Fix CombineGlobally with GlobalWindows (apache#26922)
c81e051 
Adds a better error message when this is used in an unsupported way as well as more testing.
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
@liferoad @aleksandr-dudko
Fix CombineGlobally with GlobalWindows (apache#26922)
cd707d9 
Adds a better error message when this is used in an unsupported way as well as more testing.
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@liferoad @cushon
Fix CombineGlobally with GlobalWindows (apache#26922)
7adcd2d 
Adds a better error message when this is used in an unsupported way as well as more testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwb robertwb robertwb approved these changes

@tvalentyn tvalentyn tvalentyn approved these changes

Assignees
No one assigned
Labels
Next Action: Reviewers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liferoad @tvalentyn @robertwb