-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hint to CounterCell #27522
Add type hint to CounterCell #27522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27522 +/- ##
==========================================
- Coverage 71.16% 70.96% -0.21%
==========================================
Files 861 865 +4
Lines 104547 105453 +906
==========================================
+ Hits 74401 74834 +433
- Misses 28597 29070 +473
Partials 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PyDoc failure is as a result of #28104 |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run PythonDocs PreCommit |
The assessment in #27469 is that the issue is in TFX code - is that incorrect? |
It is, this just also adds a type hint to the metric counter that should give a more clear type check error rather than the error only coming when the metric is serialized. |
gotcha, nice, thanks! |
retest this please |
* [DO NOT MERGE] Add type hint to CounterCell * Tryt alt type hint format * Call out integer type in docstring
Experiment with adding an explicit
int
type hint to CounterCell'supdate
method. This should avoid an accidental aggregation of non-ints that is only caught when trying to serialize the metric.Should prevent #27469 in the future
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.