-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python Flink runner load tests & Stop publish Python SDK image in beam_portability #27595
Conversation
* Use beam-sdk images for load tests
run seed job |
Run Load Tests Python ParDo Flink Batch |
Run Load Tests Go ParDo Flink Batch |
See https://ci-beam.apache.org/job/beam_Publish_Docker_Snapshots/1062/ no longer build python containers, now build only job servers (flink and spark) |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
run seed job |
Run Load Tests Python ParDo Flink Batch |
Found that Python Flink runner load tests all broken since Jul 20, e.g. https://ci-beam.apache.org/view/LoadTests/job/beam_LoadTests_Python_Combine_Flink_Batch/
the first failing test run on Jul 20, 2023, 5:28 AM UTC using snapshot containers on Jul 19, 2023, 8:45 PM UTC. It appears some changes on July 18-19 broke Python container. |
Run Load Tests Python ParDo Flink Batch |
1 similar comment
Run Load Tests Python ParDo Flink Batch |
Run Load Tests Python ParDo Flink Batch Manually reset "latest" tag to 3 days ago and it still fails. So this is not relevant to beam change |
Run Load Tests Python ParDo Flink Batch |
1 similar comment
Run Load Tests Python ParDo Flink Batch |
The tests run successfully in local flink cluster. Reproduce step:
Result:
(running on Mac M1, amd64 python sdk container image is slow. If build container image locally ( |
It appears pull python image locally takes 1min40s, below the timeout of 2 min: Line 57 in 98cef8b
while it is experimented that dataproc master it takes 3 min to finish:
changed to command to increase the timeout to 10 min. However need to build a snapshot from master to take effect though |
As a check, change the timeout Line 57 in 4ffeae4
to 10s from master and run the test (#27595 (comment)) indeed encounters exact same error:
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
previously successful seed job run can be found in the test status of the first commit: ba7cace |
Run Java_PVR_Flink_Batch PreCommit |
Fixes #26921
Should fix #27601 (need job-server snapshot built on master to take effect)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.