Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable firestore integration tests (revert #27267) #27743

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 28, 2023

Fixes #25851

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Jul 28, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented Jul 28, 2023

tests still failing with same reason

@Abacn
Copy link
Contributor Author

Abacn commented Aug 3, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented Aug 7, 2023

Run PostCommit_Java_Dataflow

@Abacn
Copy link
Contributor Author

Abacn commented Aug 7, 2023

Run Java_GCP_IO_Direct PreCommit

@Abacn Abacn marked this pull request as ready for review August 9, 2023 14:30
@Abacn
Copy link
Contributor Author

Abacn commented Aug 9, 2023

Tests now passed after #27858

R: @pl04351820 @damondouglas

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Aug 9, 2023

Old run of github action failure status (tests actually passed) due to #27854 unrelated

@Abacn
Copy link
Contributor Author

Abacn commented Aug 9, 2023

Run PostCommit_Java_DataflowV2

1 similar comment
@Abacn
Copy link
Contributor Author

Abacn commented Aug 11, 2023

Run PostCommit_Java_DataflowV2

@bvolpato
Copy link
Contributor

Errors are all setup-based

Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/runner/_work/beam/beam/.github/actions/setup-action'. Did you forget to run actions/checkout before running your local action?

@Abacn Abacn merged commit 9cff2c4 into apache:master Aug 15, 2023
12 of 16 checks passed
@Abacn Abacn deleted the restorefirestoreit branch August 15, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Firestore integration tests failing affecting GCPIO_PreCommit, DataflowPostCommit V1 and V2
2 participants