Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendor guava 32.1.2-jre #27895

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Use vendor guava 32.1.2-jre #27895

merged 2 commits into from
Aug 8, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 8, 2023

Fixes #27801

The first commit is trivial 26.0-jre->32.1.2-jre replace, and the following commit(s) fix the errorprone/checkstyle rules that are introduced in new guava versions

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Fix InlineMe errorprone warning

* Fix new errorprones used in new guava

* Fix serialization test
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.
R: @damccorm for label build.
R: @chamikaramj for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #27895 (c29485f) into master (8b42b8d) will decrease coverage by 0.25%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27895      +/-   ##
==========================================
- Coverage   70.83%   70.58%   -0.25%     
==========================================
  Files         861      857       -4     
  Lines      104732   103938     -794     
==========================================
- Hits        74183    73368     -815     
- Misses      28990    29011      +21     
  Partials     1559     1559              
Flag Coverage Δ
python 79.55% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Aug 8, 2023

Run CommunityMetrics PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Aug 8, 2023

Run GoPortable PreCommit

failed twice with different reasons

-- passed in third run

@Abacn
Copy link
Contributor Author

Abacn commented Aug 8, 2023

R: @bvolpato @hlteoh37

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Aug 8, 2023

Run GoPortable PreCommit

* https://github.com/apache/beam/commit/ca0787642a6b3804a742326147281c99ae8d08d2
*/

/** This was generated manually. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit Can you comment on how this was generated manually? Or you just used the failure to set as a baseline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just used the error message which prints serializedCheckpoint to set the base line:

"KinesisReaderCheckpoint may have changed. Consider update OLDER_VERSION_SERIALIZED_CHECKPOINT: \"%s\"",

Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pushing this Yi! It will be nice to move to a newer Guava!

@Abacn
Copy link
Contributor Author

Abacn commented Aug 8, 2023

going to use merge instead of squash to preserve two commit history (one trivial replace, one fix)

@Abacn Abacn merged commit 1b6e55b into apache:master Aug 8, 2023
21 checks passed
@Abacn Abacn deleted the vendorguava branch August 8, 2023 21:14
Abacn added a commit to Abacn/beam that referenced this pull request Aug 8, 2023
@hlteoh37
Copy link
Contributor

hlteoh37 commented Aug 9, 2023

Thanks for push this fix through! @Abacn
Do we know when the next Beam release is scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment