Exclude StorageApiSinkSchemaUpdate integration tests from dataflow postcommit #27928
Conversation
|
Run PostCommit_Java_Dataflow |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| @@ -556,6 +556,7 @@ task googleCloudPlatformLegacyWorkerIntegrationTest(type: Test, dependsOn: copyG | |||
| include '**/*IT.class' | |||
| exclude '**/BigQueryIOReadIT.class' | |||
| exclude '**/BigQueryIOStorageReadTableRowIT.class' | |||
| exclude '**/StorageApiSinkSchemaUpdateIT.class' | |||
There was a problem hiding this comment.
Can we add a comment mentioning this is due to the test needing streaming engine?
There was a problem hiding this comment.
sure (will push the change after https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/188/ passed
|
I don't think this is a runner v1 issue - rather it's because the feature
used here requires streaming engine (which is available on runner v1).
…On Wed, Aug 9, 2023 at 7:36 AM Yi Hu ***@***.***> wrote:
R: @ahmedabu98 <https://github.com/ahmedabu98> @reuvenlax
<https://github.com/reuvenlax>
—
Reply to this email directly, view it on GitHub
<#27928 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAYJVK63OLPKC45Z4JL3ILXUOOAHANCNFSM6AAAAAA3KDQAT4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ ahmedabu98 virtually all users are running this sink on runner v1 today, so it would be good to get it working. |
|
Commented on the issue but mentioning here too: This may need some refactoring because I believe TestDataflowRunner doesn't support TestStream |
|
Run PostCommit_Java_Dataflow |
|
Run PostCommit_Java_DataflowV2 |
|
The refactoring is of course good; can we get this in so postcommit back green first, giving that failing tests are newly added so do not signature functioning issue @ahmedabu98 CC: @lostluck |
Abacn
changed the title
Fixes #27911
We also did similar exclusions for various IO tests on legacy runner (see code around)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.