-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin google-cloud-storage. #27931
Unpin google-cloud-storage. #27931
Conversation
Don't pin google-cloud-storage to a narrow range without a particular.
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #27931 +/- ##
==========================================
+ Coverage 70.58% 70.60% +0.02%
==========================================
Files 857 857
Lines 103947 103947
==========================================
+ Hits 73370 73393 +23
+ Misses 29018 28995 -23
Partials 1559 1559
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
As recorded in #27326, this was done because we are relying on an internal field of google-cloud-storage. If the feeling is that this is unlikely to be an issue, that's fine, but I felt like I should articulate the rationale for pinning the version in the first place. |
Thanks, that context is hard to access to a passer-by like me in this case. See the dependency management guidance here: https://docs.google.com/document/d/1euZogGjbW4VZNJMFrA5AL1keR5gZO5l45H9b9CoQ0SI/edit (I plan to publish it this week to a more visible location). If you feel that a stronger pin is required, let's add it back and add a comment. |
This reverts commit 0a8e3cc.
I sent a rollback, let's try to work with GCS team to have a resolution for this that would allow us to remove this pin. |
Don't pin google-cloud-storage to a narrow range without a particular reason.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.