Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin google-cloud-storage. #27931

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Unpin google-cloud-storage. #27931

merged 1 commit into from
Aug 9, 2023

Conversation

tvalentyn
Copy link
Contributor

Don't pin google-cloud-storage to a narrow range without a particular reason.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Don't pin google-cloud-storage to a narrow range without a particular.
@github-actions github-actions bot added the python label Aug 9, 2023
@tvalentyn
Copy link
Contributor Author

R: @Abacn @BjornPrime @johnjcasey

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@johnjcasey
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #27931 (4d2f23d) into master (4122e96) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27931      +/-   ##
==========================================
+ Coverage   70.58%   70.60%   +0.02%     
==========================================
  Files         857      857              
  Lines      103947   103947              
==========================================
+ Hits        73370    73393      +23     
+ Misses      29018    28995      -23     
  Partials     1559     1559              
Flag Coverage Δ
python 79.58% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn tvalentyn merged commit 0a8e3cc into master Aug 9, 2023
76 of 77 checks passed
@tvalentyn tvalentyn deleted the tvalentyn-patch-3 branch August 9, 2023 17:32
@BjornPrime
Copy link
Contributor

As recorded in #27326, this was done because we are relying on an internal field of google-cloud-storage. If the feeling is that this is unlikely to be an issue, that's fine, but I felt like I should articulate the rationale for pinning the version in the first place.

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Aug 10, 2023

As recorded in #27326, t

Thanks, that context is hard to access to a passer-by like me in this case. See the dependency management guidance here: https://docs.google.com/document/d/1euZogGjbW4VZNJMFrA5AL1keR5gZO5l45H9b9CoQ0SI/edit (I plan to publish it this week to a more visible location).

If you feel that a stronger pin is required, let's add it back and add a comment.

tvalentyn added a commit that referenced this pull request Aug 10, 2023
@tvalentyn
Copy link
Contributor Author

I sent a rollback, let's try to work with GCS team to have a resolution for this that would allow us to remove this pin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants