-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #27878 #27968
Revert #27878 #27968
Conversation
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #27968 +/- ##
==========================================
+ Coverage 72.04% 72.31% +0.27%
==========================================
Files 674 678 +4
Lines 98577 99662 +1085
==========================================
+ Hits 71023 72074 +1051
- Misses 25991 26025 +34
Partials 1563 1563
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 8cfd308.
This has caused some internal breakages, we should dig in to the changes before releasing them.
PR produced with:
Followed by manually resolving conflicts in setup.py and base_image_requirements.txt files. I removed the client change from setup.py and just updated the requirements files to not have any changes.
I also made a separate commit to revert the CHANGES.md update.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.