Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin hugging face docs #28106

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Pin hugging face docs #28106

merged 1 commit into from
Aug 22, 2023

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 22, 2023

The upgraded version is causing docs precommit to fail.

Part of #28104


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tvalentyn
Copy link
Contributor

Are there any implications for Beam's compatibility with the new versions ?

@damccorm
Copy link
Contributor Author

Are there any implications for Beam's compatibility with the new versions ?

I'm not sure yet. Our hugging face tests are only exercising up to 4.31, so its definitely possible. My goal is just getting us green with this PR, which is why I'm leaving the issue open

@damccorm
Copy link
Contributor Author

I'm looking at this now though

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #28106 (9c589af) into master (7a421c4) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28106      +/-   ##
==========================================
- Coverage   72.30%   72.29%   -0.01%     
==========================================
  Files         678      678              
  Lines       99771    99771              
==========================================
- Hits        72140    72131       -9     
- Misses      26068    26077       +9     
  Partials     1563     1563              
Flag Coverage Δ
python 82.85% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 01cd453 into master Aug 22, 2023
76 checks passed
@damccorm damccorm deleted the users/damccorm/docsPrecommit branch August 22, 2023 20:14
damccorm added a commit that referenced this pull request Aug 22, 2023
lostluck pushed a commit that referenced this pull request Aug 22, 2023
Polber pushed a commit to Polber/beam that referenced this pull request Aug 29, 2023
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 30, 2023
Polber pushed a commit to Polber/beam that referenced this pull request Sep 13, 2023
Polber pushed a commit to Polber/beam that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants