Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin transformers for pydoc #28436

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Sep 13, 2023

Since torch is added to autodoc_mock_import, when importing transformers it throws an error when importing from transformers import Pipeline. In one of the steps it checks the torch.__version__. Since this turns out to be None, the transformer import throws an error. This PR adds transformers to autodoc_mock_import as well and unpin transformers version.

Fixes #28104


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #28436 (d983272) into master (1032533) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28436      +/-   ##
==========================================
- Coverage   72.31%   72.30%   -0.01%     
==========================================
  Files         683      683              
  Lines      100633   100633              
==========================================
- Hits        72768    72765       -3     
- Misses      26289    26292       +3     
  Partials     1576     1576              
Flag Coverage Δ
python 82.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Sep 13, 2023

R: @damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@damccorm damccorm merged commit 5cb55b2 into apache:master Sep 13, 2023
77 checks passed
@riteshghorse riteshghorse deleted the unpin-transformers branch September 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Unpin transformers in pydocs precommit
2 participants