Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for _run_test in frames_test.py #28557

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 20, 2023

Came across this while trying to debug other things, but if a series has a non-unique index run_test would fail because ser.columns doesn't exist.

I guess none of our existing tests have non-unique indices for series.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@caneff
Copy link
Contributor Author

caneff commented Sep 20, 2023

R: @tvalentyn

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #28557 (5d6bb03) into master (603b517) will decrease coverage by 0.01%.
Report is 153 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28557      +/-   ##
==========================================
- Coverage   72.34%   72.34%   -0.01%     
==========================================
  Files         682      683       +1     
  Lines      100536   100819     +283     
==========================================
+ Hits        72737    72940     +203     
- Misses      26221    26301      +80     
  Partials     1578     1578              
Flag Coverage Δ
python 82.82% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

something is not right with test infra

@tvalentyn
Copy link
Contributor

asked in #28539

@tvalentyn
Copy link
Contributor

Checked: Dataframe precommit, formatter and lint GHA tasks, noted BUILD successful in the logs, failure is during teardown and unrelated to the PR.

@tvalentyn tvalentyn merged commit f676d93 into apache:master Sep 20, 2023
42 of 76 checks passed
@caneff caneff deleted the fix_run_test branch September 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants