-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic for _run_test in frames_test.py #28557
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @chamikaramj added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @tvalentyn |
Codecov Report
@@ Coverage Diff @@
## master #28557 +/- ##
==========================================
- Coverage 72.34% 72.34% -0.01%
==========================================
Files 682 683 +1
Lines 100536 100819 +283
==========================================
+ Hits 72737 72940 +203
- Misses 26221 26301 +80
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more. see 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
something is not right with test infra |
asked in #28539 |
Checked: Dataframe precommit, formatter and lint GHA tasks, noted BUILD successful in the logs, failure is during teardown and unrelated to the PR. |
Came across this while trying to debug other things, but if a series has a non-unique index run_test would fail because ser.columns doesn't exist.
I guess none of our existing tests have non-unique indices for series.