Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow Replacement for Jenkins Jobs, beam_PerformanceTests_ParquetIOIT* #28582

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

magicgoody
Copy link
Contributor

@magicgoody magicgoody commented Sep 21, 2023

PR migrates Jenkins Jobs to Github Actions Workflow:
".github/workflows/beam_PerformanceTests_ParquetIOIT.yml"
".github/workflows/beam_PerformanceTests_ParquetIOIT_HDFS.yml"

Jenkins Jobs:
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_ParquetIOIT/
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_ParquetIOIT_HDFS/

The code has been tested on Self-hosted GKE runners ubuntu 20.04.

Example runs:

beam_PerformanceTests_ParquetIOIT.yml https://github.com/magicgoody/beam/actions/runs/6317827565
image

beam_PerformanceTests_ParquetIOIT_HDFS.yml https://github.com/magicgoody/beam/actions/runs/6317827652
image


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 21, 2023
Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the inline comments

issue_comment:
types: [created]
schedule:
- cron: '10 3 * * *'
Copy link
Collaborator

@andreydevyatkin andreydevyatkin Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 10 3/12 * * * in accordance with the Jenkins pattern

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 10 3/12 * * * every 12 hour (jenkins pattern)

issue_comment:
types: [created]
schedule:
- cron: '50 3 * * *'
Copy link
Collaborator

@andreydevyatkin andreydevyatkin Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 50 3/12 * * * in accordance with the Jenkins pattern

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 50 3/12 * * * every 12 hour (jenkins pattern)

# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please fix the formatting for all .txt files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@magicgoody magicgoody marked this pull request as ready for review September 28, 2023 10:47
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit a6de303 into apache:master Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants