Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StorageV1 client with GCS client - Draft #28733

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BjornPrime
Copy link
Contributor

Addresses #25676.

Draft PR to maintain commit history.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: Patch coverage is 6.91489% with 175 lines in your changes are missing coverage. Please review.

Project coverage is 37.90%. Comparing base (d32a8e5) to head (20513f9).
Report is 1026 commits behind head on master.

Files Patch % Lines
sdks/python/apache_beam/io/gcp/gcsio.py 9.60% 113 Missing ⚠️
...apache_beam/runners/dataflow/internal/apiclient.py 0.00% 23 Missing ⚠️
..._beam/runners/portability/sdk_container_builder.py 0.00% 15 Missing ⚠️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 0.00% 13 Missing ⚠️
...ks/python/apache_beam/runners/interactive/utils.py 0.00% 10 Missing ⚠️
sdks/python/apache_beam/internal/gcp/auth.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28733      +/-   ##
==========================================
- Coverage   38.40%   37.90%   -0.50%     
==========================================
  Files         686      683       -3     
  Lines      101629   100677     -952     
==========================================
- Hits        39029    38163     -866     
+ Misses      61017    60931      -86     
  Partials     1583     1583              
Flag Coverage Δ
python 29.10% <6.91%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

1 similar comment
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

2 similar comments
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

1 similar comment
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Dec 30, 2023
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Mar 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 6.91489% with 175 lines in your changes missing coverage. Please review.

Project coverage is 37.90%. Comparing base (d32a8e5) to head (20513f9).
Report is 2741 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/io/gcp/gcsio.py 9.60% 113 Missing ⚠️
...apache_beam/runners/dataflow/internal/apiclient.py 0.00% 23 Missing ⚠️
..._beam/runners/portability/sdk_container_builder.py 0.00% 15 Missing ⚠️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 0.00% 13 Missing ⚠️
...ks/python/apache_beam/runners/interactive/utils.py 0.00% 10 Missing ⚠️
sdks/python/apache_beam/internal/gcp/auth.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28733      +/-   ##
==========================================
- Coverage   38.40%   37.90%   -0.50%     
==========================================
  Files         686      683       -3     
  Lines      101629   100677     -952     
==========================================
- Hits        39029    38163     -866     
+ Misses      61017    60931      -86     
  Partials     1583     1583              
Flag Coverage Δ
python 29.10% <6.91%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the stale label May 2, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jul 1, 2024
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Aug 31, 2024
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants