Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the value of MAX_BATCH_OPERATION_SIZE in gcsio #29503

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

shunping
Copy link
Contributor

This value was changed in PR #29360 to 1000, which led to internal test failure.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This value was changed in PR apache#29360 to 1000, which led to
internal test failure.
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32b1067) 37.85% compared to head (374105f) 37.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #29503   +/-   ##
=======================================
  Coverage   37.85%   37.85%           
=======================================
  Files         690      690           
  Lines      101306   101306           
=======================================
  Hits        38350    38350           
  Misses      61363    61363           
  Partials     1593     1593           
Flag Coverage Δ
python 29.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

LGTM

@johnjcasey johnjcasey merged commit 392a4a1 into apache:master Nov 21, 2023
83 checks passed
riteshghorse pushed a commit to riteshghorse/beam that referenced this pull request Nov 21, 2023
This value was changed in PR apache#29360 to 1000, which led to
internal test failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants