Re-enable checker for files excluded to due bug (now fixed) #29932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
io
extensions
runners
spark
sql
dataflow
direct
gcp
kudu
core
samza
labels
|
One moment - spotless does not apply to |
kennknowles
force-pushed
the
no-more-checker-bug
branch
2 times, most recently
from
35e3c19
to
6c2b700
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
kennknowles
force-pushed
the
no-more-checker-bug
branch
from
6c2b700
to
53af47e
Compare
|
run spotless precommit |
|
Cannot reproduce any of these failures :-/ |
|
run spotless precommit |
kennknowles
force-pushed
the
no-more-checker-bug
branch
from
53af47e
to
aa02757
Compare
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Actually this was really just to make #29924 simpler but I went too far and I'll just path this one up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugs that we discovered and reported to checkerframework have been fixed. This re-enables checkerframework for those files.
To create this pull request, I re-enabled checker for all files, and then re-disabled it for a few files that still have issues. So the new status is fully up to date (for the version of checker we are using)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.