Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two flaky tests #30278

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Fix two flaky tests #30278

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06490ef
Fix a flaky test caused by race condition
shunping Feb 9, 2024
3d72cbf
Use notify and wait per reviewer request
shunping Feb 9, 2024
d437cab
Increase assert threshold to allow more room for extra threads
shunping Feb 9, 2024
9ffd54b
Move synchronized block outside of assertThrows
shunping Feb 9, 2024
4a004f5
Replace this with isReady when defining synchronized block
shunping Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ public void testCloseVisibleToAwaitCompletionCallerAndProducer() throws Exceptio
Future<?> future2 =
executor.submit(
() -> {
Thread.sleep(500); // give the previous future some time to reach the inf while loop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Busy sleep is generally not preferable. Consider use wait/notify which sounds exactly what we need here? That is block this thread until future1 reaches while(true)

observer.close();
return null;
});
Expand Down
Loading