Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry test_big_query_write_temp_table_append_schema_update up to 3 times #31364

Merged
merged 6 commits into from
May 24, 2024

Conversation

liferoad
Copy link
Collaborator

@liferoad liferoad commented May 21, 2024

Addresses #30513.

Following #31350, retry the entire test for now.

For this test: test_big_query_write_insert_non_transient_api_call_error, we occasionally see this error:

[1m�[31mERROR   �[0m apache_beam.runners.common:bundle_processor.py:237 BigQuery job beam_bq_job_COPY_AUTOMATIC_JOB_NAME_COPY_STEP_76772e260e0c46cf96f0b94402c2595d_2af7745dca2d9060a22b202c77bbc2d8 failed. Error Result: <ErrorProto |  
-- | --
  | message: 'Error encountered during execution. Retrying may solve the problem.' |  
  | reason: 'backendError'> [while running 'write/BigQueryBatchFileLoads/ParDo(TriggerCopyJobs)/ParDo(TriggerCopyJobs)']

The reason is not clear but the BQ copy job is already done although the error could be retried. To really retry this, we need to retry the entire copy job. Given STREAMING_INSERTS is not recommended any more, we decided to just retry the test for now.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

PTAL at my comment in 0b617e0#r1598786964

@liferoad
Copy link
Collaborator Author

Got it. I will follow #31247.

@liferoad liferoad requested review from tvalentyn and removed request for Abacn May 24, 2024 14:22
@tvalentyn
Copy link
Contributor

PTAL at PreCommit Python Lint / beam_PreCommit_PythonLint (Run PythonLint PreCommit) (pull_request_target) Failing after 16m

@tvalentyn tvalentyn merged commit 3b9b6ed into apache:master May 24, 2024
87 of 89 checks passed
@tvalentyn tvalentyn changed the title added pytest.mark.flaky for test_big_query_write_temp_table_append_sc… retry test_big_query_write_temp_table_append_schema_update up to 3 times May 24, 2024
@tvalentyn
Copy link
Contributor

@liferoad could you please add details to the PR description about the nature of flakiness in case someone looks up this PR to understand why we aded it? Thanks!

@liferoad
Copy link
Collaborator Author

@liferoad could you please add details to the PR description about the nature of flakiness in case someone looks up this PR to understand why we aded it? Thanks!

More details are in the closed PR, which is in the description, :)

@liferoad
Copy link
Collaborator Author

@liferoad could you please add details to the PR description about the nature of flakiness in case someone looks up this PR to understand why we aded it? Thanks!

More details are in the closed PR, which is in the description, :)

updated the descriptions with more details now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants