Solace Read connector: watermark-calculation related classes #31595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields serializable.
…r - unnecessary." This reverts commit 2e1c10e.
# Conflicts: # .github/workflows/beam_PreCommit_Java_Solace_IO_Direct.yml # sdks/java/io/solace/build.gradle
# Conflicts: # sdks/java/io/solace/build.gradle
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…-0-watermark # Conflicts: # sdks/java/io/solace/build.gradle # sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java
Abacn
reviewed
Jun 17, 2024
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/read/WatermarkPolicy.java
Show resolved
Hide resolved
|
Documentation added, thank you @Abacn! |
3 tasks
Abacn
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the Solace Read connector (addresses #31440).
Adds watermark-related classes.
Depends on #31594
Relevant changes:
https://github.com/apache/beam/pull/31595/commits/3847876ed9a26ef2177d9544ddd83986a3d96541Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.